Multinode Access Patch

Patch to add Multinode Access UI to node.module. Patch is named:

node.module.multinode.patch

Upgrading the patch to 6.x. Here are the functions where updating needs to take place:

• node_menu($may_cache)
• node_access($op, $node = NULL)
• _node_access_where_sql
• node_access_grants
• node_access_view_all_nodes()
• node_access_grants_sql
• node_multinode($theme = NULL)
• theme_node_multinode($form)
• node_multinode_submit($form_id, $form_values)

Here are the details:

• node_menu($may_cache)

  $items['admin/content/multinode'] = array(
  'title' => t('Multinode user interface'),
  'description' => t('Interface for configuring multiple node access.'),
  'page callback' => 'drupal_get_form',
  'page arguments' => array('node_multinode'),
  'access arguments' => user_access('administer nodes'),
  'type' => MENU_NORMAL_ITEM
  );

• node_access($op, $node = NULL)

  if ($op != 'create' && $node->nid && $node->status) {
  $grants_sql = node_access_grants_sql($op, NULL, $user->uid, $node->status);
  // If the return value is FALSE, then the node status is unpublished and
  // none of the grants requested an access check be run. In which case,
  // we should fall through to the final 'if' statement.
  if ($grants_sql !== FALSE) {
  if (!empty($grants_sql)) {
  $grants_sql .= ' AND';
  }
  $sql = "SELECT COUNT(*) FROM {node_access} WHERE (nid = 0 OR nid = %d) $grants_sql grant_$op >= 1";
  $result = db_query($sql, $node->nid);
  return (db_result($result));
  }
  }

• _node_access_where_sql

  $grants_sql = node_access_grants_sql('view', $node_access_alias, $account->uid);

  Note that in original patch this was:

  $grants_sql = node_access_grants_sql('view', $node_access_alias, $uid);

  Apparently, in 6.x the $account object is used. But, our code is still expecting only the $accunt->uid.

• node_access_grants($op, $account = NULL)
  
  Nothing to change. Although this now requires $account object instead of $account->uid (in Drupal 5.x)
• node_access_view_all_nodes()

  $grants_sql = node_access_grants_sql('view');

• node_access_grants_sql

  This is our own custom code, although I do need to modify in order to get the $account object for calling node_access_grants(). Previously, I only needed the $account->uid.

  $rules = node_access_grants($op, $account);

• node_multinode($theme = NULL)

  This is our own custom code, although I do need to modify in order to get the $account object for calling node_access_grants(). Previously, I only needed the $account->uid.

  $mrules = node_access_grants($op, $account);

• theme_node_multinode($form)
• node_multinode_submit($form_id, $form_values)
  This has to change to:

  node_multinode_submit($form, $form_state)

  as per Drupal 6.x upgrade.

  So, this code:

  foreach ($form_values as $block) {

  becomes this:

  foreach ($form_state['values'] as $block) {

1. Copied modified system.install to test.scbbs.com.
2. System automatically let me know that system.module update 6048 needed to be ran.
3. Ran it. Got error " user warning: Table 'multinode_access' already exists query:". Of course. Table was created by OG User Roles!
4. Uploaded modified node.module to test.scbbs.com.
5. Now getting this error:

   warning: Invalid argument supplied for foreach() in /var/www/html/websites/drupal/test/includes/menu.inc on line 258

   Must be from menu settings or the $account issue.

6. Running php tests. theme_node_multinode() just doesn't seem to apply.
7. Posted issue here: http://drupal.org/node/279254
8. Resolved: I needed to clear the menu cache: admin->site configuration->performance